This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Fix LTO ICE introduced by ggc_collect patch

From: Jan Hubicka <hubicka at ucw dot cz>
To: Andrew Pinski <pinskia at gmail dot com>
Cc: Jan Hubicka <hubicka at ucw dot cz>, gcc-patches at gcc dot gnu dot org
Date: Thu, 9 Sep 2010 02:16:12 +0200
Subject: Re: Fix LTO ICE introduced by ggc_collect patch
References: <20100909000520.GC21068@kam.mff.cuni.cz> <AANLkTi=snSD+JBk-9DXJJ_uC9WnzbfF4SKFCn_41r1pd@mail.gmail.com>

> On Wed, Sep 8, 2010 at 5:05 PM, Jan Hubicka <hubicka@ucw.cz> wrote:
> > - ?free(decl_data);
> > + ?ggc_free(decl_data);
> > + ?real_file_decl_data = NULL;
> 
> Should you zero real_file_count also (well maybe -1).

Well, i guess it is harmless to keep it alone since GGC code tests
pointer for non-NULL first.
Obviously some places in LTO code could use conversion to VECtors...

Honza
> 
> Thanks,
> Andrew Pinski

References:
- Fix LTO ICE introduced by ggc_collect patch
  - From: Jan Hubicka
- Re: Fix LTO ICE introduced by ggc_collect patch
  - From: Andrew Pinski

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]