Re: [PATCH] Fix PR45393

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Mon, Aug 30, 2010 at 6:27 AM, Richard Guenther <rguenther@suse.de> wrote:
> On Mon, 30 Aug 2010, H.J. Lu wrote:
>
>> On Wed, Aug 25, 2010 at 3:45 AM, Richard Guenther <rguenther@suse.de> wrote:
>> >
>> > In sincos detection we forgot to properly move EH regions. ?Fixed as
>> > follows.
>> >
>> > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk
>> > sofar.
>> >
>> > Richard.
>> >
>> > 2010-08-25 ?Richard Guenther ?<rguenther@suse.de>
>> >
>> > ? ? ? ?PR tree-optimization/45393
>> > ? ? ? ?* tree-ssa-math-opts.c (execute_cse_sincos_1): Properly transfer
>> > ? ? ? ?and clean EH info. ?Avoid SSA update.
>> > ? ? ? ?(execute_cse_sincos): Cleanup the CFG if it has changed.
>> >
>> > ? ? ? ?* g++.dg/torture/pr45393.C: New testcase.
>> >
>>
>> I backported it to gcc 4.5. OK for 4.5?
>
> Ok.
>

On 4.4 branch, I got

pr45393.cc:20: error: BB 4 can not throw but has EH edges
pr45393.cc:20: error: BB 5 can not throw but has EH edges
pr45393.cc:20: internal compiler error: verify_flow_info failed
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

when checking isn't disabled.  Here is the patch for 4.4.  OK
for 4.4 if regression tests on Linux/x86-64 pass?

Thanks.

-- 
H.J.

Attachment: gcc-4.4-pr45393-1.patch
Description: Text document