This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: ARM patch: Add "insn" attribute to more patterns.

From: Bernd Schmidt <bernds at codesourcery dot com>
To: Richard Earnshaw <rearnsha at arm dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Sat, 28 Aug 2010 00:15:17 +0200
Subject: Re: ARM patch: Add "insn" attribute to more patterns.
References: <4C6BB412.6080601@codesourcery.com> <1282640412.9849.11.camel@e102346-lin.cambridge.arm.com>

On 08/24/2010 11:00 AM, Richard Earnshaw wrote:

> Your patch is inconsistent in how you've terminated patterns.  The
> prevailing style in the ARM machine description is for the bracket that
> closes a pattern to be on a line of its own (starting in the first
> column).  Please stick to the prevailing style rather than gratuitously
> changing things.
> 
> OK once that's fixed.

Committed with this change.  I've made similar changes before out of
habit, since this style is inconsistent with how RTL is usually written
and it wastes vertical space.  Can we change it in config/arm?

Bernd

References:
- ARM patch: Add "insn" attribute to more patterns.
  - From: Bernd Schmidt
- Re: ARM patch: Add "insn" attribute to more patterns.
  - From: Richard Earnshaw

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]