This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [vect] Ask for review and approving the patch about vect and loongson
On Sat, Aug 21, 2010 at 10:29 AM, Richard Sandiford
<rdsandiford@googlemail.com> wrote:
> Uros Bizjak <ubizjak@gmail.com> writes:
>> On Tue, Aug 17, 2010 at 11:49 AM, Mingjie Xing <mingjie.xing@gmail.com> wrote:
>>> Updated. See the attachment.
>>
>> Perhaps we should extend the comment a bit:
>>
>> +# Check whether the vectorizer tests are supported by the target and append
>> +# additional target-dependent compile flags to DEFAULT_VECTFLAGS. ?Also
>> +# set dg-do-what-default to either compile or run, depending on target
>> +# capabilities. ?Return 1 if vectorizer tests are supported by
>> target, 0 otherwise.
>>
>>> Is it OK?
>>
>> Looks OK to me. ?Richi, can you please formally approve the patch?
>
> Seems like this might have got stuck. ?Mingjie's original patch is
> certainly a step forward in its own right, so Mingjie, please feel free
> to commit your original MIPS-specific gcc.dg/vect/vect.exp patch if you
> don't get an approval for this one in the next couple of days. ?Please
> update the other two vect.exps in the same way, at the same time.
As we do not have an (active) testsuite maintainer right now please treat
target specific changes as covered by your target maintainership.
Richard.
> Richard
>