This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [pach, Fortran] Improve dependency checking
- From: Thomas Koenig <tkoenig at netcologne dot de>
- To: Daniel Kraft <d at domob dot eu>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Mon, 09 Aug 2010 21:38:11 +0200
- Subject: Re: [pach, Fortran] Improve dependency checking
- References: <1281378170.3622.5.camel@linux-fd1f.site> <4C605269.7080000@domob.eu>
Hi Daniel,
> Ok. Just two comments:
>
> + /* Fill in the upper bound, which may be lower than the
> + specified one for something like a(2:10:5), which is
> + identical to a(2:7:5). Only relevant for non-zero strides.
> */
Now replaced with "strides not equal to one." Thanks for pointing
this out!
> And secondly, I do not oppose your extension of gfc_ref_dimen_size;
> however, it seems to me that you could have implemented a
> gfc_ref_dimen_end function easily by calling gfc_ref_dimen_size from
> it,
> instead of duplicating the code. So if you want, you could do this
> instead?
I would also have had to write the code to access the start, or factor
that out of gfc_ref_dimen_size as well.
Übertrage Daten .......
Revision 163041 übertragen.
Thanks for the quick review!
Thomas