This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Hookize TARGET_ASM_OUTPUT_ADDR_CONST_EXTRA

From: "Anatoly Sokolov" <aesok at post dot ru>
To: <gcc-patches at gcc dot gnu dot org>, "Dominique Dhumieres" <dominiq at lps dot ens dot fr>
Date: Sat, 7 Aug 2010 15:06:23 +0400
Subject: Re: [PATCH] Hookize TARGET_ASM_OUTPUT_ADDR_CONST_EXTRA
References: <20100807103013.D5C883BE18@mailhost.lps.ens.fr>

Hi.
From: "Dominique Dhumieres" <dominiq@lps.ens.fr>

This patch turns TARGET_ASM_OUTPUT_ADDR_CONST_EXTRA macro into a hook.
  The patch has been bootstrapped on and regression tested on
x86_64-unknown-linux-gnu for c and c++.


Athough I don't understand anything about the hook changes I find
quite wierd that it is tested on x86_64-unknown-linux-gnu only
and not on other platforms and that OUTPUT_ADDR_CONST_EXTRA is
removed on config/i386/ only. A grep for OUTPUT_ADDR_CONST_EXTRA
on gcc/config/* returns

gcc/config/arm/arm.h:#define OUTPUT_ADDR_CONST_EXTRA(file, x, fail) \

....

gcc/config/xtensa/xtensa.h:#define OUTPUT_ADDR_CONST_EXTRA(STREAM, X, FAIL) \
I am quite surprised that OUTPUT_ADDR_CONST_EXTRA is not removed
also for the non i386 platforms. Am I wrong?

Because compilation and testings time of the GCC for each platform very big, I prefer hookize target macros tatget-by-target.

Anatoly.

Follow-Ups:
- Hook-ize-ing
  - From: IainS

References:
- Re: [PATCH] Hookize TARGET_ASM_OUTPUT_ADDR_CONST_EXTRA
  - From: Dominique Dhumieres

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]