This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 6/9] Emit the prologue/epilogue using frame offsets.

From: Richard Henderson <rth at twiddle dot net>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org, kai dot tietz at onevision dot com, ubizjak at gmail dot com
Date: Thu, 05 Aug 2010 11:56:02 -0700
Subject: Re: [PATCH 6/9] Emit the prologue/epilogue using frame offsets.
References: <1280879596-1089-1-git-send-email-rth@twiddle.net> <1280879596-1089-7-git-send-email-rth@twiddle.net> <AANLkTinWsWR2mo9k=WGYHx08iG+wpoqGpgeB4OvJQHht@mail.gmail.com> <4C5AD86F.3020206@twiddle.net> <AANLkTimxsBjMS=WR06+v5+v1P_Qvksx5AFmCTh4G0-tP@mail.gmail.com> <4C5ADBA8.7050706@twiddle.net> <AANLkTikHEMBe=bnadmgPV8N9KPTQvwUFDQX5Y8buYuFq@mail.gmail.com> <AANLkTi=grvFmgf+72ak2icHKqBs=J8vogqyNKkKYmsca@mail.gmail.com> <4C5AFE39.8090008@twiddle.net> <AANLkTik83zfc+5Y0G9jL_=iYMG531y3_Nv1P=B5uDtdP@mail.gmail.com> <4C5B0273.9030907@twiddle.net> <AANLkTi=Y6GsEgZ11mCF5OXXvSSU1bAXfhUt9iQH-u8gA@mail.gmail.com>

On 08/05/2010 11:30 AM, H.J. Lu wrote:
> I think this patch is clearer and also fixes the issue.

> -	  addr = GEN_INT (-crtl->stack_alignment_needed / BITS_PER_UNIT);
> +	  addr = GEN_INT (-(crtl->stack_alignment_needed
> +			    / BITS_PER_UNIT));

Not quite.  Here you get 0xfffffff0u not -16, which is different
for 64-bit HOST_WIDE_INT.  Which technically works, but the unwind
info is larger since -16 encodes smaller.

r~

References:
- [PATCH 0/9] Cleanups to i386 prologue/epilogue generation
  - From: Richard Henderson
- [PATCH 6/9] Emit the prologue/epilogue using frame offsets.
  - From: Richard Henderson
- Re: [PATCH 6/9] Emit the prologue/epilogue using frame offsets.
  - From: H.J. Lu
- Re: [PATCH 6/9] Emit the prologue/epilogue using frame offsets.
  - From: Richard Henderson
- Re: [PATCH 6/9] Emit the prologue/epilogue using frame offsets.
  - From: H.J. Lu
- Re: [PATCH 6/9] Emit the prologue/epilogue using frame offsets.
  - From: Richard Henderson
- Re: [PATCH 6/9] Emit the prologue/epilogue using frame offsets.
  - From: H.J. Lu
- Re: [PATCH 6/9] Emit the prologue/epilogue using frame offsets.
  - From: H.J. Lu
- Re: [PATCH 6/9] Emit the prologue/epilogue using frame offsets.
  - From: Richard Henderson
- Re: [PATCH 6/9] Emit the prologue/epilogue using frame offsets.
  - From: H.J. Lu
- Re: [PATCH 6/9] Emit the prologue/epilogue using frame offsets.
  - From: Richard Henderson
- Re: [PATCH 6/9] Emit the prologue/epilogue using frame offsets.
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]