This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 0/9] Cleanups to i386 prologue/epilogue generation
- From: Jack Howarth <howarth at bromo dot med dot uc dot edu>
- To: Richard Henderson <rth at redhat dot com>
- Cc: Richard Henderson <rth at twiddle dot net>, gcc-patches at gcc dot gnu dot org, kai dot tietz at onevision dot com, ubizjak at gmail dot com
- Date: Wed, 4 Aug 2010 20:14:36 -0400
- Subject: Re: [PATCH 0/9] Cleanups to i386 prologue/epilogue generation
- References: <1280879596-1089-1-git-send-email-rth@twiddle.net> <4C5A006B.4090409@redhat.com>
On Wed, Aug 04, 2010 at 05:06:03PM -0700, Richard Henderson wrote:
> On 08/03/2010 04:53 PM, Richard Henderson wrote:
> > Tested on x86_64-linux. There are no code generation changes within
> > x86_64 cc1 after the patch series. Final testing on i686-linux is
> > yet to complete; I'll check on that tomorrow morning.
>
> I committed this patch series after fixing a bug on i686.
>
> /* Special care must be taken for the normal return case of a function
> using eh_return: the eax and edx registers are marked as saved, but
> not restored along this path. Adjust the save location to match. */
> if (crtl->calls_eh_return && style != 2)
> frame.reg_save_offset -= 2 * UNITS_PER_WORD;
>
> This hunk had gotten lost somehow from patch 7, ix86_expand_epilogue.
> (Probably I did something stupid and synced things the wrong way between
> machines during testing.) Re-adding it fixes a few exception failures
> for 32-bit.
>
> I also consulted with Jack Howarth about the darwin oddity. He has filed
> a radar bug report against the linker. Since the resulting executables
> work, he agreed to add the linker warning to the pruning if a linker fix
> is not forthcoming.
>
Radar://8274440, "ld: warning: can't add line info to anonymous symbol",
with two standalone testcases generated before and after the patch.
>
> r~