This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Improve linker errors for missing key method definitions
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Jeffrey Yasskin <jyasskin at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 04 Aug 2010 13:30:32 -0700
- Subject: Re: [patch] Improve linker errors for missing key method definitions
- References: <AANLkTimZESJr8--O6nZG7EULVNjVVdZZPdZbkKYpke8Z@mail.gmail.com> <AANLkTimPes2iZOWJ4351PDmZ8yrbRf10j4EmBwdwRd31@mail.gmail.com> <AANLkTilTRXGPIujfQk5QVqdkr9cQbDRLiCk1KfdWLs6L@mail.gmail.com> <AANLkTintVJIHFvQbL6boVZuxfuDHgNMd2oSj-EtQd0Mz@mail.gmail.com> <4C437461.9070803@codesourcery.com> <AANLkTiks_ghAL-xVdmGi0tvjPo6p-YSDguhlO-7005aa@mail.gmail.com> <AANLkTi==MeN+TNa8+wW+0arqQS1saDJ-6MDs0HJB9+iP@mail.gmail.com>
Jeffrey Yasskin wrote:
> Mark, do you think you'll get a chance to review this patch?
I apologize for being slow to respond to this.
> The patch at http://gcc.gnu.org/ml/gcc-patches/2010-07/msg01124/keymethod.patch
> still applies and passes check-g++. The changelog was in
> http://gcc.gnu.org/ml/gcc-patches/2010-07/msg01116.html.
I like the idea of improving diagnostics and I do understand that this
is a situation that can be difficult to debug. However, I don't really
like the idea of changing code-generation in this way in order to
trigger the error. I'd rather have the compiler emit some non-code
annotation that the linker could use. Perhaps, with -g, this could just
be an additional DWARF annotation somewhere.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713