This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch Darwin 2/2] fix PPC64 ABI
- From: Nathan Froyd <froydnj at codesourcery dot com>
- To: IainS <developer at sandoe-acoustics dot co dot uk>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, mrs at gcc dot gnu dot org, David Edelsohn <dje dot gcc at gmail dot com>
- Date: Sat, 24 Jul 2010 03:13:12 -0700
- Subject: Re: [Patch Darwin 2/2] fix PPC64 ABI
- References: <9C2B0543-065F-4BFB-B3E1-C2E138A54927@sandoe-acoustics.co.uk>
On Sat, Jul 24, 2010 at 09:36:14AM +0100, IainS wrote:
> Index: gcc/config/rs6000/rs6000.c
> ===================================================================
> --- gcc/config/rs6000/rs6000.c (revision 162457)
> +++ gcc/config/rs6000/rs6000.c (working copy)
> @@ -8931,6 +8995,51 @@ rs6000_gimplify_va_arg (tree valist, tree type,
> gi
> return build_va_arg_indirect_ref (t);
> }
>
> +#if TARGET_MACHO
Could we avoid introducing more #if TARGET_MACHO where it's not
necessary? It should be sufficient to say something like:
if (TARGET_MACHO
&& rs6000_darwin_abi
&& integer_zerop (TYPE_SIZE (type)))
...
and the compiler will DTRT and fold out that code for non-Darwin
targets. (This comment applies equally to your other darwin64 patch.)
-Nathan