This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [CFT, try 9] Emulated tls rewrite
On Wed, Jul 21, 2010 at 12:38:30PM -0700, Richard Henderson wrote:
> On 07/21/2010 09:32 AM, Richard Henderson wrote:
> > On 07/21/2010 01:23 AM, Richard Guenther wrote:
> >> Couldn't you do gsi_insert_on_edge_immediate?
> >
> > I could. It doesn't really help though, since the location@which
> > the call statement and the call edge are created is shared between
> > the normal statements and the phi statements. It gets ugly either way.
>
> As discussed on IRC, what do you think of this incremental patch?
>
> I've tested it on tls.exp and see no failures. I'll start a proper
> bootstrap and test in a moment to see that there are no other
> unexpected consequences.
>
>
>
> r~
>
Richard,
I am still seeing one additional failure in the gfortran testsuite
(with the expanded tls test set) under your emutls patch that wasn't
present with Iain's original version. For the gfortran.dg/gomp/appendix-a/a.22.6.f90
testcase with...
! { dg-require-effective-target tls }
I get the failure...
Executing on host: /sw/src/fink.build/gcc46-4.6.0-1000/darwin_objdir/gcc/testsuite/gfortran/../../gfortran -B/sw/src/fink.build/gcc46-4.6.0-1000/darwin_objdir/gcc/testsuite/gfortran/../../ /sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100721/gcc/testsuite/gfortran.dg/gomp/appendix-a/a.22.6.f90 -O -fopenmp -S -o a.22.6.s (timeout = 300)
/sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100721/gcc/testsuite/gfortran.dg/gomp/appendix-a/a.22.6.f90:4:0: sorry, unimplemented: thread-local COMMON data not implemented^M
compiler exited with status 1
output is:
/sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100721/gcc/testsuite/gfortran.dg/gomp/appendix-a/a.22.6.f90:4:0: sorry, unimplemented: thread-local COMMON data not implemented^M
FAIL: gfortran.dg/gomp/appendix-a/a.22.6.f90 -O (test for excess errors)
Excess errors:
/sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100721/gcc/testsuite/gfortran.dg/gomp/appendix-a/a.22.6.f90:4:0: sorry, unimplemented: thread-local COMMON data not implemented
Any idea why your version (with the emutls code as a pass) fails gfortran.dg/gomp/appendix-a/a.22.6.f90
and Iain's version didn't?
Jack