This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch i386]: Add for win32 targets pre-prologue profiling feature


2010/7/14 Dave Korn <dave.korn.cygwin@gmail.com>:
> On 14/07/2010 11:20, Kai Tietz wrote:
>
>> ? ? ? * config/i386/cygming.h (PROFILE_SUPPORT_BEFORE_PROLOGUE): New.
>> ? ? ? (MCOUNT_NAME): Win32 specific version.
>
>> +
>> +/* Choose the correct profiler mcount name. For checking we are using the
>> + ? ix86_profile_before_prologue function as flag_profile_top is tri-state. ?*/
>> +#undef MCOUNT_NAME
>> +#define MCOUNT_NAME (ix86_profile_before_prologue () ? "_mcount_top" : "_mcount")
>> +
>> ?#if ! defined (USE_MINGW64_LEADING_UNDERSCORES)
>> ?#undef USER_LABEL_PREFIX
>> ?#define USER_LABEL_PREFIX (TARGET_64BIT ? "" : "_")
>
>
> ?Shouldn't MCOUNT_NAME take USER_LABEL_PREFIX into account?
>
> ? ?cheers,
> ? ? ?DaveK
>
>

Well, as this MCOUNT_NAME ("_mcount") is already used widely for
64-bit, I don't want to change here something. But in general you are
right.

Cheers,
Kai

-- 
|? (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]