This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PING -- MicroBlaze target support patches
- From: Gerald Pfeifer <gerald at pfeifer dot com>
- To: Michael Eager <eager at eagerm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, gcc at gcc dot gnu dot org
- Date: Sat, 10 Jul 2010 20:04:33 +0200 (CEST)
- Subject: Re: PING -- MicroBlaze target support patches
- References: <4BEB0738.5060704@eagerm.com>
On Wed, 12 May 2010, Michael Eager wrote:
> Could someone please review these patches?
>
> Add support for Xilinx MicroBlaze processor:
>
> http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01903.html
This is okay with three small changes.
Please use "Do not" instead of "Don't" in invoke.texi.
Use proper markup for -fno-zero-initialized-in-bss in the same.
Similarly, please use @var in
Supported values are in the format vX.YY.Z, where X is a major version,
YY is the minor version, and Z is compatiblity code.
in invoke.texi.
> http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01905.html
> http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01908.html
> http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01907.html
These three I cannot review/approve, but the strike me as pretty
straightforward, not touching lots of core code? Where are we
regarding this? Is this stuck somewhere?
> http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01906.html
This is fine, too. For the announcement on the main page, let's say
"processor" (lower case) and there is a closing </p> missing on the
changes.html page.
Good work!
Gerald