This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [24/27] Put gcse's can_copy hash into target structures
Richard Henderson <rth@redhat.com> writes:
> On 07/07/2010 02:30 PM, Richard Sandiford wrote:
>> + /* Nonzero for each mode that supports (set (reg) (reg)).
>> + This is trivially true for integer and floating point values.
>> + It may or may not be true for condition codes. */
>> + int x_can_copy[(int) NUM_MACHINE_MODES];
> ...
>> -static char can_copy[(int) NUM_MACHINE_MODES];
>
> Type changed.
Gah, good catch. That was careless.
> For the most part I think *most* of the "char" variables that
> you're moving should really be "bool". However, I think that
> should be done in separate changes.
Yeah, agreed that bool would be nicer. I vaguely recall a discussion
about whether that was a good idea though, given that hosts like Darwin
define bool to be wider than char. More fool them, I suppose.
Richard