This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch PR 44576]: Reduce the computation cost in compute_miss_rate for prefetching loop arrays

From: Richard Guenther <richard dot guenther at gmail dot com>
To: "Fang, Changpeng" <Changpeng dot Fang at amd dot com>
Cc: Zdenek Dvorak <rakdver at kam dot mff dot cuni dot cz>, Christian Borntraeger <borntraeger at de dot ibm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "uweigand at de dot ibm dot com" <uweigand at de dot ibm dot com>, "sebpop at gmail dot com" <sebpop at gmail dot com>
Date: Wed, 30 Jun 2010 19:44:45 +0200
Subject: Re: [Patch PR 44576]: Reduce the computation cost in compute_miss_rate for prefetching loop arrays
References: <D4C76825A6780047854A11E93CDE84D02F7759@SAUSEXMBP01.amd.com> <AANLkTimL0po55_PnkbcCe2lbJNlaeWmcLeRqy48kTBen@mail.gmail.com> <D4C76825A6780047854A11E93CDE84D02F775B@SAUSEXMBP01.amd.com>

On Wed, Jun 30, 2010 at 7:34 PM, Fang, Changpeng <Changpeng.Fang@amd.com> wrote:
>> FOR_EACH_LOOP (li, loop, LI_ONLY_INNERMOST)
>
>>does that make a difference?
>
> This doesn't help, because "compute_all_dependences" was called the same number of time
> as before.
>
> (BTW, should we limit prefetching only to the innermost one?)
>
> In this test case, there are 6 large loops, where each loop has 729 memory reference.
> It takes 4~5 seconds to "compute_all_dependence" for one such loop.

It shouldn't take that long.  Can you gather a more detailed profile?

>
>> The patch passed Bootstrapping and regression tests.
>>
>> Is this patch OK to commit?
>
>>Ok.
>
> ?Thank you.
>
> Changpeng
>

Follow-Ups:
- Re: [Patch PR 44576]: Reduce the computation cost in compute_miss_rate for prefetching loop arrays
  - From: Zdenek Dvorak

References:
- [Patch PR 44576]: Reduce the computation cost in compute_miss_rate for prefetching loop arrays
  - From: Fang, Changpeng
- Re: [Patch PR 44576]: Reduce the computation cost in compute_miss_rate for prefetching loop arrays
  - From: Richard Guenther
- RE: [Patch PR 44576]: Reduce the computation cost in compute_miss_rate for prefetching loop arrays
  - From: Fang, Changpeng

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]