On Tue, Jun 29, 2010 at 8:23 PM, Maxim Kuvyrkov<maxim@codesourcery.com> wrote:
On 6/24/10 7:53 PM, Maxim Kuvyrkov wrote:
...
This updated patch corrects the cleaning routine and adds several
comments to annotate its actions.
Ping.
Also, in case you haven't look at the patch yet, here is yet another version
with a fix to potential miscompilation of code with EH. Otherwise the patch
is the same.
A miscompilation can occur due to VBEout sets not filtering out expressions
that die to due to abnormal control flow, these expression are represented
in TRANSPOUT set. This updated version (a) filters out VBEout sets with
!TRANSPOUT and (b) adds a check to hoist_expr_reaches_here_p() that accounts
for TRANSPOUT. Previously, the check in hoist_code() would suffice because
we never looked too far down the CFG.
The ideal patch would remove TRANSPOUT and clean out those expressions
earlier, see what RTL PRE does.
If you clean that up first, this latest version 0003 patch will
probably look better/simpler.