This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix comment in c-family/c-common.h
Actually, I am wrong. Since toplev.h still includes diagnostic-core.h,
this is still true. So common.h has to be included before both
toplev.h and diagnostic-core.h
BTW, check the top of cp-tree.h for the check that I added to better
diagnose this problem. I guess it applies here also.
Cheers,
Manuel.
On 28 June 2010 21:16, Manuel López-Ibáñez <lopezibanez@gmail.com> wrote:
> This obvious, you do not need anyone's approval for such a change. Go for it!
>
> Manuel.
>
> On 28 June 2010 21:05, Andrew Pinski <pinskia@gmail.com> wrote:
>> I caught this comment fix when I was looking at c-common.h.
>> diagnostic-core.h is now the file which contains error/warning/sorry
>> rather than toplev.h.
>>
>> OK?
>>
>> Thanks,
>> Andrew Pinski
>>
>> ChangeLog:
>> * c-common.h: Update comment for the location change of the diagnostic
>> functions.
>>
>