This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Committed : [PATCH, LTO] add externally_visible attribute when necessary with -fwhole-program and resolution file.
Changed names of flags and committed at r161483
2010-06-28 Bingfeng Mei <bmei@broadcom.com>
* cgraph.h (struct varpool_node): new used_from_object_file flag.
(struct cgraph_local_info): new used_from_object_file flag.
* cgraph.c (dump_cgraph_node): dump used_from_object_file flag.
(cgraph_clone_node): initialize used_from_object_file.
(cgraph_create_virtual_clone): initialize used_from_object_file.
* lto-symbtab.c (lto_symtab_merge_decls_1): Set
used_from_object_file flags for symbols of LDPR_PREVAILING_DEF
when compiling with -fwhole-program.
(lto_symtab_resolve_symbols) Use LDPR_PREVAILING_DEF_IRONLY for
internal resolver.
* ipa.c (function_and_variable_visibility): Set externally_visible
flag of varpool_node if used_from_object_file flag is set.
(cgraph_externally_visible_p): check used_from_object_file flag.
* doc/invoke.texi (-fwhole-program option): Change description of
externally_visible attribute accordingly.
* doc/extend.texi (externally_visible): Ditto.
> -----Original Message-----
> From: Jan Hubicka [mailto:hubicka@ucw.cz]
> Sent: 28 June 2010 10:47
> To: Bingfeng Mei
> Cc: Jan Hubicka; gcc-patches@gcc.gnu.org; Richard Guenther
> Subject: Re: PING: [PATCH, LTO] add externally_visible attribute when
> necessary with -fwhole-program and resolution file.
>
> > Honza,
> >
> > Could you comment on the modified patch? As you suggested, I added
> > new "externally_visible_by_resolver" flags only for this purpose.
> > The relevant places in ipa.c are updated to check this flag. It
> passes tests
> > and is bootstrapped. OK for trunk?
>
> The patch is OK. Since we already have used_from_other_partition for
> similar purpose,
> I guess it would be better to call the flag used_from_object_file.
>
> Honza
> >
> > Thanks,
> > Bingfeng
> >
> > 2010-06-21 Bingfeng Mei <bmei@broadcom.com>
> >
> > * lto-symbtab.c (lto_symtab_merge_decls_1): Set
> > externally_visible_by_resolver flags for symbols of
> > LDPR_PREVAILING_DEF when compiling with -fwhole-program.
> > (lto_symtab_resolve_symbols) Use LDPR_PREVAILING_DEF_IRONLY
> for
> > internal resolver.
> > * ipa.c (function_and_variable_visibility): Set
> externally_visible
> > flag of varpool_node if externally_visible_by_resolver flag
> is set.
> > (cgraph_externally_visible_p): check
> externally_visible_by_resolver
> > flag.
> > * cgraph.h (struct varpool_node): new
> externally_visible_by_resolver
> > flag. (struct cgraph_local_info): new
> externally_visible_by_resolver
> > flag.
> > * cgraph.c (dump_cgraph_node): dump
> externally_visible_by_resolver
> > flag. (cgraph_clone_node): initialize
> externally_visible_by_resolver.
> > (cgraph_create_virtual_clone): initialize
> externally_visible_by_resolver.
> > * doc/invoke.texi (-fwhole-program option): Change
> description of
> > externally_visible attribute accordingly.
> > * doc/extend.texi (externally_visible): Ditto.
> >
> >
>
>
- References:
- Re: [PATCH, LTO] add externally_visible attribute when necessary with -fwhole-program and resolution file.
- RE: [PATCH, LTO] add externally_visible attribute when necessary with -fwhole-program and resolution file.
- Re: [PATCH, LTO] add externally_visible attribute when necessary with -fwhole-program and resolution file.
- RE: [PATCH, LTO] add externally_visible attribute when necessary with -fwhole-program and resolution file.
- Re: [PATCH, LTO] add externally_visible attribute when necessary with -fwhole-program and resolution file.
- PING: [PATCH, LTO] add externally_visible attribute when necessary with -fwhole-program and resolution file.
- Re: PING: [PATCH, LTO] add externally_visible attribute when necessary with -fwhole-program and resolution file.
- RE: PING: [PATCH, LTO] add externally_visible attribute when necessary with -fwhole-program and resolution file.
- Re: PING: [PATCH, LTO] add externally_visible attribute when necessary with -fwhole-program and resolution file.
- PING: [PATCH, LTO] add externally_visible attribute when necessary with -fwhole-program and resolution file.
- Re: PING: [PATCH, LTO] add externally_visible attribute when necessary with -fwhole-program and resolution file.