This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Micro optimize bitmap_clear_bit
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: gcc-patches at gcc dot gnu dot org, rguenther at suse dot de
- Date: Tue, 22 Jun 2010 14:51:42 +0200
- Subject: Re: Micro optimize bitmap_clear_bit
- References: <20100622123003.GB15547@kam.mff.cuni.cz>
On 06/22/2010 02:30 PM, Jan Hubicka wrote:
> The patch seems to save about 10% of samples on bitmap_clear_bit, but it is
> within noise factor.
>
To be frank, I don't understand this stance. As I see this type of
issue, either you have independent reasons to believe that the patch is
beneficial and just go ahead, or you should repeat the test enough times
and in the correct conditions until you reach statistical significance.
Otherwise, I don't believe it really makes sense to mention numbers
which you don't trust yourself...
Paolo.