This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [fortran,patch] Higher-level access to floating-point builtins
- From: FX <fxcoudert at gmail dot com>
- To: Tobias Burnus <tobias dot burnus at physik dot fu-berlin dot de>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Fri, 11 Jun 2010 21:38:50 +0200
- Subject: Re: [fortran,patch] Higher-level access to floating-point builtins
- References: <20100611154020.GB18233@physik.fu-berlin.de>
> + /* For now, we assume that if real(kind=10) exists, it is long double.
> + Later, we will deal with __float128 and break this assumption. */
>
> I think that should be kind=16.
Yes, in that comment, it should be. Fixed, changed.
> Looks fine to me - and it is certainly better not to assume the
> real(kind=4/8/(10,16)) = C's float/double/long double correspondence.
Well, we still assume it in many places... just, in trans-intrinsic.c, it's now a lot more localized :)
Thanks for the review,
FX