This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, toplevel/config] fix tls.m4 configure race condition (bootstrap/PR43170)
On Tue, Jun 08, 2010 at 07:28:26PM +0200, Paolo Bonzini wrote:
> On 06/08/2010 07:27 PM, Jakub Jelinek wrote:
>> On Tue, Jun 08, 2010@07:10:58PM +0200, Paolo Bonzini wrote:
>>>> Is volatile required here because we want to peek behind implementation
>>>> details that are not supposed to be observable, and observable features
>>>> of threads don't need them?
>>>
>>> In "int volatile *volatile"
>>> ^^^^^^^^ ^^^^^^^^
>>> This one is to This one is probably superfluous.
>>> ensure emutls You could also remove the * in
>>> get_address is the second line.
>>> called.
>>
>> The first volatile isn't needed. That affects accesses to a, but that is
>> something that doesn't happen in the program@all.
>
> Oops, yes, I exchanged the two. Better go home.
>
> Paolo
>
Paolo,
So the original patch is okay for gcc trunk?
Jack