This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Move C front end to its own directory (1/3)


On Sat, Jun 5, 2010 at 3:29 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> On Sat, Jun 5, 2010 at 12:26 PM, Joseph S. Myers
> <joseph@codesourcery.com> wrote:
>> On Sat, 29 May 2010, Steven Bosscher wrote:
>>
>>> Most of this is trivial updating of paths. The only complication is
>>> that gengtype does not understand that files can come from
>>> subdirectories that are not front-end specific, so I needed a rather
>>
>> Neither does po/exgettext, which looks for directories with config-lang.in
>> plus the config/ directory and its immediate subdirectories. ?So that
>> script will need to know about c-family as well.
>
> OK, that is not very difficult, the following patch would suffice for now:
> -------------------- 8< -----------------------
> Index: po/exgettext
> ===================================================================
> --- po/exgettext ? ? ? ?(revision 160279)
> +++ po/exgettext ? ? ? ?(working copy)
> @@ -84,7 +84,7 @@ echo "scanning for keywords, %e and %n s
>
> ?( cd $srcdir
> ? lang_subdirs=`echo */config-lang.in */*/config-lang.in | sed -e
> 's|config-lang\.in||g'`
> - ?{ for dir in "" config/ config/*/ $lang_subdirs
> + ?{ for dir in "" c-family/ config/ config/*/ $lang_subdirs
> ? ? do ?for glob in '*.c' '*.h' '*.def'
> ? ? ? ? do ?eval echo $dir$glob
> ? ? ? ? done
> -------------------- 8< -----------------------
>
>
> (Longer term, we would have to add support for subdirectories in
> general, i.e. not just the lang_subdirs, if more files would be moved
> from gcc/ to separate directories, e.g. all GIMPLE optimizations. But
> for now, one extra hard-coded directory is not a real problem, is it?)
>
>>
>> I have not yet otherwise reviewed the patch.
>
> Note that there is really not so *that* to review. I think the most
> important bits of the patch (and the hardest to keep in sync until the
> patch is approved) are the Makefile.in bits. Eventually I think there
> should be a separate Make* file in c-family/ but that is for a later
> patch (again, we'll need some form of support for subdirectories in
> general).

Btw, I guess it would be nice to delay the commit of this (and followp)
patches until after the gc-improv merge which is due on next Tuesday.

Richard.

> Ciao!
> Steven
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]