This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [build, libjava, v3, testsuite] Unreviewed patches/backport requests
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Andrew Haley <aph at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
- Date: Fri, 04 Jun 2010 12:40:28 +0200
- Subject: Re: [build, libjava, v3, testsuite] Unreviewed patches/backport requests
- References: <yddvda1fgb5.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <4C07662B.8030607@redhat.com>
Andrew Haley <aph@redhat.com> writes:
> On 06/02/2010 07:19 PM, Rainer Orth wrote:
>> The following patches have remained unreviewed for some time:
>>
>> [build, classpath] Avoid unportable diff -u/-U
>> http://gcc.gnu.org/ml/gcc-patches/2010-05/msg01881.html
>>
>> Needs a libjava maintainer to approve the check_jni_methods.sh.in part.
>>
>> [build, v3] 4.4 backport requests
>> http://gcc.gnu.org/ml/gcc-patches/2010-05/msg02158.html
>>
>> Needs build and/or libstdc++ maintainers.
>>
>> [testsuite] 4.4 backport requests
>> http://gcc.gnu.org/ml/gcc-patches/2010-05/msg02165.html
>>
>
> Hmm, these are fairly unpleasant changes, so I'm not surprised no-one
> approved them. I'll say OK, but are there really no readable diff
> options on Solaris?
Not before Solaris 10, which added -u/-U. But other platforms are
affected as well (like IRIX and Tru64 UNIX). Since the diff output
isn't intended for human consumption in those cases (unlike
contrib/compare-all-tests) and absense of GNU diff breaks bootstrap, I
think this is a good change to make.
When having to actually read diff output, I strongly prefer diff -u
myself.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University