This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] gc-improv merge (2/n): make gengtype output typed allocators

From: Laurynas Biveinis <laurynas dot biveinis at gmail dot com>
To: Richard Guenther <richard dot guenther at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org, Diego Novillo <dnovillo at google dot com>
Date: Fri, 28 May 2010 14:14:07 +0200
Subject: Re: [PATCH] gc-improv merge (2/n): make gengtype output typed allocators
References: <AANLkTil7aqBjbXaYm4dU4CF9KmpHge5_HmU3hyRzJ5j0@mail.gmail.com> <AANLkTikM1WZhQg9fC1ur9zzITwI1qzfC50YlN-htqVQh@mail.gmail.com>

2010/5/25 Richard Guenther <richard.guenther@gmail.com>:
> + Âbool third_arg = (zone == specific_zone) && (variable_size
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â|| (quantity == vector));
>
> please use an extra pair of () and align the && vertically instead.

OK.

>
> +/* ÂWrites a typed GC allocator for type S that is suitable as a callback for
> + Â Âthe splay tree implementation in libiberty. Â*/
>
> too many leading spaces.

OK.

> Ok with the above changes.

Thanks,

-- 
Laurynas

References:
- [PATCH] gc-improv merge (2/n): make gengtype output typed allocators
  - From: Laurynas Biveinis
- Re: [PATCH] gc-improv merge (2/n): make gengtype output typed allocators
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]