This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, C] PR18249

From: "Joseph S. Myers" <joseph at codesourcery dot com>
To: Shujing Zhao <pearly dot zhao at oracle dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Paolo Carlini <paolo dot carlini at oracle dot com>
Date: Sun, 23 May 2010 13:44:51 +0000 (UTC)
Subject: Re: [PATCH, C] PR18249
References: <4BF3BDAE.20301@oracle.com> <Pine.LNX.4.64.1005191055050.14382@digraph.polyomino.org.uk> <4BF4F6AB.7090709@oracle.com> <Pine.LNX.4.64.1005201551480.31411@digraph.polyomino.org.uk> <4BF665E8.9020205@oracle.com>

On Fri, 21 May 2010, Shujing Zhao wrote:

> +	      case NIC_STAR:
> +		msg = "%<.%>";

This should be "*".  The "." seems wrong and you're using %qs below so no 
explicit %< and %> should be here.

OK with that change if there are no objections from C++ front-end 
maintainers within 48 hours.

-- 
Joseph S. Myers
joseph@codesourcery.com

References:
- [PATCH, C] PR18249
  - From: Shujing Zhao
- Re: [PATCH, C] PR18249
  - From: Joseph S. Myers
- Re: [PATCH, C] PR18249
  - From: Shujing Zhao
- Re: [PATCH, C] PR18249
  - From: Joseph S. Myers
- Re: [PATCH, C] PR18249
  - From: Shujing Zhao

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]