This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] More include cleanups

From: Richard Guenther <richard dot guenther at gmail dot com>
To: Steven Bosscher <stevenb dot gcc at gmail dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 21 May 2010 13:38:53 +0200
Subject: Re: [patch] More include cleanups
References: <AANLkTinF-Fnm5Vy6NMQJDbxxd8QCYE9nLZDcuWSBCwKL@mail.gmail.com> <AANLkTilVgWfc1Y6HMnNpMtnG8LCmeQvP4lCmBjkUTEXx@mail.gmail.com> <AANLkTin2qyCzoP-AS_LQJPJQ_yDMJbySInQA3kF94Dlw@mail.gmail.com> <AANLkTikZt6CR-2-NagP2WYI1bgeO3A0d6qxB1J-D3d_7@mail.gmail.com>

On Fri, May 21, 2010 at 1:38 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> On Fri, May 21, 2010 at 1:29 PM, Richard Guenther
> <richard.guenther@gmail.com> wrote:
>> The main reason I am concerned is that real.h pulls in
>> all of gmp.h, mpfr.h and mpc.h (and machmode.h which is generated).
>
> Well, yes that is not ideal.
> On the other hand: This already happened before, too, via rtl.h
>
> The problem is that real.h includes those files. I objected to t hat
> at the time! IMHO gmp.h/mpfr.h/mpc.c should be included in those files
> that use them. I think that's only builtins.c and fold-const.c. ?I can
> work on this as a follow-up if you like.

That would be nice.

Thanks,
Richard.

References:
- [patch] More include cleanups
  - From: Steven Bosscher
- Re: [patch] More include cleanups
  - From: Richard Guenther
- Re: [patch] More include cleanups
  - From: Richard Guenther
- Re: [patch] More include cleanups
  - From: Steven Bosscher

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]