This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] More include cleanups
On Fri, May 21, 2010 at 1:33 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> On Fri, May 21, 2010 at 1:27 PM, Richard Guenther
> <richard.guenther@gmail.com> wrote:
>> On Fri, May 21, 2010 at 1:19 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
>>> Hi,
>>>
>>> This started as an attempt to remove rtl headers from tree*.c, but I
>>> found out that you end up including real.h in all those files instead
>>> of rtl.h.
>>
>> Did you track down why they need real.h? ?If it is just because
>> of struct real_value in interfaces we might want to include that
>> in coretypes.h instead?
>
> Most of them need it for things like HONOR_NANS.
Ok, I guess if we want to avoid gmp.h and friends we should try
to do that locally in real.h instead.
>>> So I included real.h in tree.h, and fixed-value.h too for good
>>> measure. ?Can't do that, of course, without cleaning up all the places
>>> where those two files were already included. There is still a long way
>>> to go, but IMHO this is a step in the right direction.
>>
>> It doesn't include fixed-value.h either.
>
> Not sure what you mean. After the patch:
> $ grep fixed-value.h *.[ch] */*.[ch] */*/*.[ch]
> rtl.h:#include "fixed-value.h"
> tree.h:#include "fixed-value.h"
Oh, indeed.
The patch is ok with a proper Makefile.in change then.
Thanks,
Richard.
> Ciao!
> Steven
>