Re: [Patch, Fortran] OOP cleanup

[Janus Weil <janus at gcc dot gnu dot org>]

>> Comments? Suggestions? Ok for trunk?
>
> OK for trunk, subject to a few remarks.
>
> (i) The copyright years in class.c need only be 2009 and 2010;
> (ii) Please add a comment to the top of class.c to say that it
> contains the front end functions needed to service OOP. ?We should
> expand this later to include some documentation of the representation,
> as in trans-array.c;

Thanks for your remarks, Paul. I have corrected the copyright years
and added some rudimentary documentation on the internal
representation of the class containers and vtables (which can/should
be expanded later).


> (iii) I would also shift to class.c resolve_typebound_function and
> resolve_typebound_subroutine since they implement dynamic dispatch;
> and
> (iv) You might contemplate the value of moving resolve_compcall and
> its dependencies as well. ?If you do this, add Daniel Kraft to the
> guilty parties :-)

I have not moved any stuff from resolve.c yet. I had a quick look, but
it is not completely trivial to separate out the routines you
suggested, since they have various dependencies on other routines in
resolve.c (which one would either have to move along, or make them
non-static). I have not found an optimal solution for this, and I'm
not 100% convinced yet that it makes sense to rip stuff out of
resolve.c at all. So I'm deferring this for the moment and will think
about it a bit more.

In the meantime, I will already commit the attached version (probably
tonight), unless anyone objects.

Cheers,
Janus

Attachment: oop_cleanup.diff
Description: Binary data