This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix PR fortran/44135

From: Mikael Morin <mikael dot morin at sfr dot fr>
To: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Fri, 14 May 2010 22:43:02 +0200
Subject: Re: [PATCH] Fix PR fortran/44135
References: <20100514182750.GA37952@troutmask.apl.washington.edu>

On 14.05.2010 20:27, Steve Kargl wrote:

The attached patch has been regtested on x86_64-*-freebsd.

The problem is an invalid computation of an array size
due to using mpz_get_ui() to retrieve the array dimensions
where the array is A(-2:0).  Using mpz_get_si() corrects
the issue.

OK for trunk?
OK for 4.4 and 4.5 trunk when my regtesting completes?

OK
It could go in as obvious actually.

Mikael

2010-05-14 Steven G. Kargl<kargl@gcc.gnu.org>
	PR fortran/44135
	* gfortran.dg/actual_array_interface_2.f90: New test.
2010-05-14 Steven G. Kargl<kargl@gcc.gnu.org>
	PR fortran/44135
	* fortran/interface.c (get_sym_storage_size): Use signed instead of
	unsigned mpz_get_?i routines.

Follow-Ups:
- Re: [PATCH] Fix PR fortran/44135
  - From: Steve Kargl

References:
- [PATCH] Fix PR fortran/44135
  - From: Steve Kargl

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]