This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix removal of trivially empty bb's even in CFGRTL mode (PR middle-end/44102)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Steven Bosscher <stevenb dot gcc at gmail dot com>
- Cc: Richard Guenther <rguenther at suse dot de>, Richard Henderson <rth at redhat dot com>, Jan Hubicka <jh at suse dot cz>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 13 May 2010 16:01:05 +0200
- Subject: Re: [PATCH] Fix removal of trivially empty bb's even in CFGRTL mode (PR middle-end/44102)
- References: <20100513104444.GZ2817@tyan-ft48-01.lab.bos.redhat.com> <AANLkTilMVk2WmV2rPWoSlMseVRbUZLEHLd9qN9Jic8KQ@mail.gmail.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, May 13, 2010 at 03:24:11PM +0200, Steven Bosscher wrote:
> On Thu, May 13, 2010 at 12:44 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> > On the attached testcase (which is basically asmgoto-4.c, just with ensuring
> > RTL EH pass is invoked on it) the trivially empty bb caused by
> > __builtin_unreachable () isn't deleted in cfglayout mode, but already during
> > RTL EH pass, and unfortunately the BARRIER after it is dropped, which
> > results in CFG verification failures.
> >
> > This patch ensures the barrier stays.
> >
> > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk/4.5?
>
> This seems wrong, header and footer should be NULL when not in cfglayout mode.
The patch touches neither header nor footer fields in cfgrtl mode.
Jakub