This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [fortran, patch] reduce noise of -Wconversion

From: Daniel Franke <franke dot daniel at gmail dot com>
To: Tobias Burnus <burnus at net-b dot de>
Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Sat, 8 May 2010 21:13:03 +0200
Subject: Re: [fortran, patch] reduce noise of -Wconversion
References: <201005081915.53758.franke.daniel@gmail.com> <201005082052.03043.franke.daniel@gmail.com> <4BE5B650.3020906@net-b.de>

On Saturday 08 May 2010 21:06:56 Tobias Burnus wrote:
> >> I am wondering whether we need some -Wconversion-extra option.
> >> 
> >> I think regarding disabling, I like the new middle-end feature, which
> >> prints the warning flag in squared brackets after the warning message
> > 
> > While correct, I fail to see the relationship to the patch?!
> 
> Well, one directly sees which warning comes from -Wconversion-extra and
> which one from -Wconversion-extra, making it easier to disable only one
> kind of conversion warnings without the other and without studying
> in-depth the manual to find out that one can disable part of the warning.


Hmm, yes. Now it makes sense :)

Then I'd suggest to fully review the patch and apply it if acceptable.
Afterwards, open an enhancement PR to implement -Wconversion-all (?).

Combining the two gets messy quickly.

Cheers

	Daniel

References:
- [fortran, patch] reduce noise of -Wconversion
  - From: Daniel Franke
- Re: [fortran, patch] reduce noise of -Wconversion
  - From: Daniel Franke
- Re: [fortran, patch] reduce noise of -Wconversion
  - From: Tobias Burnus

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]