This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, fortran] Fix PR40728 - bogus error, ice-on-invalid
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Daniel Franke <franke at embl-hamburg dot de>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Fri, 7 May 2010 06:56:26 +0200
- Subject: Re: [patch, fortran] Fix PR40728 - bogus error, ice-on-invalid
- References: <201005062303.59119.franke@embl-hamburg.de>
Daniel,
That's OK for trunk and 4.5.
Thanks for the patch.
Paul
On Thu, May 6, 2010 at 11:03 PM, Daniel Franke <franke@embl-hamburg.de> wrote:
>
> Hi all.
>
> Attached patch fixes a bogus error and an ICE when a particular standard is
> selected.
>
> The problem was, that resolve.c (specific_sym) assumes that the symbol of the
> deselected intrinsic is a specific symbol because sym->attr.external was
> already set by intrinsic.c (gfc_is_intrinsic). The patch removes the side
> effect of setting attr.external in the latter function and - voila.
>
>
> gcc/fortran/:
> 2010-05-06 ?Daniel Franke ?<franke.daniel@gmail.com>
>
> ? ? ? ?PR fortran/40728
> ? ? ? ?* intrinc.c (gfc_is_intrinsic): Do not prematurely mark symbol
> ? ? ? ?as external.
>
>
> gcc/testsuite/:
> 2010-05-06 ?Daniel Franke ?<franke.daniel@gmail.com>
>
> ? ? ? ?PR fortran/40728
> ? ? ? ?* gfortran.dg/coarray_1.f90: Fixed error message.
> ? ? ? ?* gfortran.dg/selected_char_kind_3.f90: Fixed error message.
> ? ? ? ?* gfortran.dg/intrinsic_std_1.f90: Fixed bogus message.
> ? ? ? ?* gfortran.dg/intrinsic_std_5.f90: New.
>
>
> Regression tested on i686-pc-linux-gnu.
>
> Ok for trunk? 4.5?
>
> ? ? ? ?Daniel
>
--
The knack of flying is learning how to throw yourself at the ground and miss.
--Hitchhikers Guide to the Galaxy