This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] gc-improv merge (1/n): new libiberty interfaces
On Wed, May 5, 2010 at 4:15 PM, Basile Starynkevitch
<basile@starynkevitch.net> wrote:
> On Wed, May 05, 2010 at 03:36:34PM +0200, Laurynas Biveinis wrote:
>>
>> splay_tree_new_with_separate_allocators
>> htab_create_alloc_with_separate_allocators
>>
>> The names are quite clumsy, any better suggestions?
>
> I tend to like long & descriptive names, so I am happy with your
> proposed names (as a general hint, I believe all our new global names
> should be longer than the habits ten or twenty years ago). However, if
> some people like shorter names, we might consider
> splay_tree_new_sep_alloc & htab_create_sep_alloc or something
> similar. My personal opinion is that your proposed names
> splay_tree_new_with_separate_allocators &
> htab_create_alloc_with_separate_allocators are in fact better!
Or even shorter, htab_create_alloc_sep, following htab_create_alloc_ex.
splay_tree_new_with_separate_allocators is fine I think,
following the long existing name.
But I can't approve the patch.
Richard.