This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING][PR gcov-profile/43341] Make layout of gcov structures fixed
- From: Steven Bosscher <stevenb dot gcc at gmail dot com>
- To: Alexander Monakov <amonakov at ispras dot ru>
- Cc: gcc-patches at gcc dot gnu dot org, Nathan Sidwell <nathan at codesourcery dot com>, Jan Hubicka <hubicka at ucw dot cz>
- Date: Wed, 5 May 2010 12:16:43 +0200
- Subject: Re: [PING][PR gcov-profile/43341] Make layout of gcov structures fixed
- References: <alpine.LNX.2.00.1004222128210.308@monoid.intra.ispras.ru> <alpine.LNX.2.00.1005051318190.11133@monoid.intra.ispras.ru>
On Wed, May 5, 2010 at 11:35 AM, Alexander Monakov <amonakov@ispras.ru> wrote:
> ? /* FIXME: use build_constructor directly. ?*/
> ? value = build_constructor_from_list (type, nreverse (value));
You could fix this FIXME while you're here.
If you do that, watch out: build_constructor_from_list sets
TREE_CONSTANT on the constructor, but build_constructor does not. I
have a patch to fix that, let me know if you want to have it.
Ciao!
Steven