This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PING: two middle-end builtin cproj patches
- From: Gerald Pfeifer <gerald at pfeifer dot com>
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Cc: Richard Guenther <richard dot guenther at gmail dot com>, gcc-patches at gcc dot gnu dot org
- Date: Sun, 2 May 2010 17:21:10 +0200 (CEST)
- Subject: Re: PING: two middle-end builtin cproj patches
- References: <Pine.GSO.4.58.1004100220020.2502@caipclassic.rutgers.edu> <Pine.GSO.4.58.1004181244290.16032@caipclassic.rutgers.edu> <n2u84fc9c001004181043wd256128cm25d4e5adc075577f@mail.gmail.com> <5B7CB7D206E849B79EA681B1B242CDC4@glap>
On Sun, 25 Apr 2010, Kaveh R. Ghazi wrote:
> and here is the update to the webpage:
This looks good from what I can tell. Minor comments below:
> Index: changes.html
> ===================================================================
> + <li>Versions of the GNU C library up to and including 2.11.1
> + included an <a
> + href="http://sourceware.org/bugzilla/show_bug.cgi?id=10401">incorrect
> + implementation of the <code>cproj</code> function</a>. GCC
Have you considered saying "provided a" to avoid the double use of
"include"?
> + optimizes its builtin <code>cproj</code> according to the behavior
> + specified and allowed by the ISO C99 standard. If you want to
> + avoid discrepancies between the C library and GCC's builtin
> + transformations when using <code>cproj</code> in your code, use
> + GLIBC 2.12 or later.
When used as an adjective, http://gcc.gnu.org/codingconventions.html
indicates that we shall use "built-in" (with a dash).
And how about "between the GNU C library..., use version 2.12 or later"?
This avoids "GLIBC" (which is not so standard, the project itselfs seems
to use glibc more often) and makes it yet more clear that if someone is
using a different libc she doesn't need to be concerned.
Gerald