This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: patch for pr43869
2010/4/29 Steven Bosscher <stevenb.gcc@gmail.com>:
> On Mon, Apr 26, 2010 at 9:36 PM, Maarten Lankhorst
> <m.b.lankhorst@gmail.com> wrote:
>> The bug is improper passing of arguments from a ms_abi to a sysv function,
>> because SSE_REGPARMS is equal to X86_64_REGPARMS or X86_64_MS_REGPARMS,
>> depending on the abi of the current function.
>>
>> The testcase is part of the patch, I didn't add a testcase for the ms_abi ->
>> sysv varargs case, but it is potentially affected as well, it would just be
>> harder to trigger.
>>
>> I guess a changelog entry would be:
>>
>> pr43869:
>> * i386.c: Make sure that the correct regparm is passed.
>> * testsuite/gcc.c-target/pr43869.c: Add test.
>
> The paths are always relative to the location of the ChangeLog. So you
> would have:
>
> For gcc/ChangeLog:
>
> ? ? ? ?PR target/43869
> ? ? ? ?* config/i386/i386.c: Make sure that the correct regparm is passed.
>
> For gcc/testsuite/ChangeLog (test suite has its own ChangeLog):
>
> ? ? ? ?PR target/43869
> ? ? ? ?* gcc.c-target/pr43869.c: New test.
>
> If you generate the patch, try to use the -p option (I always do "svn
> diff -x -up") so that it's easy to see which function you changed.
>
> I can't review the patch (backends, not my thing!) but I think it
> would be helpful if you can resubmit the patch taking these comments
> into account. Correctly formatted patches means fewer meta-things to
> comment on for the reviewer :-) You can add an i386 port maintainer to
> the CC: to increase your chances of a quick review/approval.
>
> Ciao!
> Steven
>
Hello Maarten,
as Steven mentioned before, the ChangeLog for gcc itself and testsuite
are different. Also you should mention each function you modified.
In general ChangeLog entries having the following format (you can take
a look to the existing ChangeLog files for details):
<date> Name <e-mail>
<tab>* <file> (<function/macro/type-name): <what-you-changed>
for more then one change per file add additional changes as
<tab>(<function/macro/type-name): <what-you-changed>
As this patch has more then 10-lines change it is necessary commonly
that you need FSF papers AFAIK. As I know you don't have such until
now and as I hope you will contribute in future more good patches like
this, please do the paper work with FSF.
Thanks for you work and research,
Kai
--
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination