This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [libiberty] Always expose both DOS and Unix variants of IS_DIR_SEPARATOR, IS_ABSOLUTE_PATH, lrealpath, ...
Ian pointed me at a discussion at gcc-help@ where it was
reported that this change broke some builds, due to
a new unconditional definition of PATH_SEPARATOR:
<http://gcc.gnu.org/ml/gcc-help/2010-04/msg00274.html>
It turns out that I don't really needed to add it to
filenames.h in the version of the gdb patch that landed in
the tree; I got rid of the need for it from an earlier version
of the patch that never made it to the public, so, we can just
remove it, and forget I ever added it in the first place.
Funny enough, I also forgot mentioning PATH_SEPARATOR
in the ChangeLog in the patch that landed in the tree...
There's a hunk below that fixes that, in case you want to have
history consistent.
Sorry I missed this before.
If okay, please apply it for me, as I don't have svn write
access.
--
Pedro Alves
2010-04-26 Pedro Alves <pedro@codesourcery.com>
* filenames.h (PATH_SEPARATOR): Delete.
---
include/ChangeLog | 1 +
include/filenames.h | 2 --
2 files changed, 1 insertion(+), 2 deletions(-)
Index: src/include/filenames.h
===================================================================
--- src.orig/include/filenames.h 2010-04-26 15:12:46.000000000 +0100
+++ src/include/filenames.h 2010-04-26 15:13:03.000000000 +0100
@@ -34,12 +34,10 @@ extern "C" {
# ifndef HAVE_DOS_BASED_FILE_SYSTEM
# define HAVE_DOS_BASED_FILE_SYSTEM 1
# endif
-# define PATH_SEPARATOR ';'
# define HAS_DRIVE_SPEC(f) HAS_DOS_DRIVE_SPEC (f)
# define IS_DIR_SEPARATOR(c) IS_DOS_DIR_SEPARATOR (c)
# define IS_ABSOLUTE_PATH(f) IS_DOS_ABSOLUTE_PATH (f)
#else /* not DOSish */
-# define PATH_SEPARATOR ':'
# define HAS_DRIVE_SPEC(f) (0)
# define IS_DIR_SEPARATOR(c) IS_UNIX_DIR_SEPARATOR (c)
# define IS_ABSOLUTE_PATH(f) IS_UNIX_ABSOLUTE_PATH (f)
Index: src/include/ChangeLog
===================================================================
--- src.orig/include/ChangeLog 2010-04-26 15:15:59.000000000 +0100
+++ src/include/ChangeLog 2010-04-26 15:16:02.000000000 +0100
@@ -3,6 +3,7 @@
* filenames.h (IS_DIR_SEPARATOR_1): Rename from IS_DIR_SEPARATOR,
always define it independently of host, add `dos_based' parameter,
and handle it.
+ (PATH_SEPARATOR): Define.
(HAS_DRIVE_SPEC_1): Rename from HAS_DRIVE_SPEC, always define it
independently of host, add `dos_based' parameter, and handle it.
(IS_ABSOLUTE_PATH_1): Rename from IS_ABSOLUTE_PATH, always define