Re: [PATCH] [loop] Move various lambda* types to obstack out of GC

[Richard Guenther <richard dot guenther at gmail dot com>]

On Thu, Apr 22, 2010 at 12:01 PM, Laurynas Biveinis
<laurynas.biveinis@gmail.com> wrote:
> 2010/4/21 Richard Guenther <richard.guenther@gmail.com>:
>> +static
>> +lambda_loop lambda_loop_new (struct obstack * lambda_obstack)
>>
>> new-line after the return type (maybe in more places).
>
> OK. Also I have fixed spaces vs. TABs as pointed out by Joseph in the
> other patch review.
>
>>
>> The function needs a comment.
>
> Like this?
>
> /* Create a new lambda loop in a given obstack. ?*/

/* Create a new lambda loop in LAMBDA_OBSTACK.  */

> static lambda_loop
> lambda_loop_new (struct obstack * lambda_obstack)
> {
> ?lambda_loop result = (lambda_loop)
> ? ?obstack_alloc (lambda_obstack, sizeof (struct lambda_loop_s));
> ?memset (result, 0, sizeof (struct lambda_loop_s));
> ?return result;
> }

Thanks,
Richard.

> Thanks,
>
> --
> Laurynas
>