Re: [DRAGONEGG] Expose 4 functions in i386.c

[Jan Hubicka <hubicka at ucw dot cz>]

> On Tue, Apr 13, 2010 at 06:25:55PM +0200, Duncan Sands wrote:
> > Hi Jan,
> >
> >>>> Aren't at least one of these a target hook? Why can't you use the target
> >>>> hooks?
> >>>
> >>> thanks for thinking about this.  As far as I can see none of these are target
> >>> hooks.  Which one were you thinking of?  As for why I can't use target hooks,
> >>
> >> These functions are used to implement x86-64 ABI (as you probably know). I.e. to tell
> >> you where argument stays.  There are target hooks to pass these decisions into calls.c
> >> via CUMULATIVE_ARGS, so search for these.
> >
> > I completely agree.  As I tried to explain in the bit you snipped (maybe I
> > wasn't very clear) I also think that the plugin can get all the information
> > it needs from the target hooks.  The question is whether it is nonetheless ok
> > to apply this to the gcc-4.5 branch in order to make things easier for my
> > users, even though it is technically the wrong thing to do in the long term.
> >
> > Ciao,
> >
> > Duncan.
> 
> Duncan,
>    From my point of view, I can certainly just add this patch
> manually to my fink gcc45 packages (and MacPorts can do the
> same). I am less concerned about the patch being accepted into
> the FSF gcc tree than it is being reviewed as something that won't
> destabilize the compiler if we use it.
Exporting functions that are not references from other units should not change
anything ;)

Honza
>          Jack