This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, fortran] PR 40539 Document internal representation of LOGICAL variables
On Wed, Apr 7, 2010 at 16:26, Tobias Burnus <burnus@net-b.de> wrote:
> On 04/07/2010 02:43 PM, Janne Blomqvist wrote:
>> Well, as ISO_C_BINDING was not used in the PR, it's a bit unreasonable
>> to expect it to help that case.
>>
> Well, it was mentioned: ifort also uses -1 for .true._c_bool ...
Yes, but that's clearly a bug in ifort. As you pointed out yourself in
the PR, C99 requires that _Bool uses 1 for .true. I suppose gfortran
is a bit lucky here, having chosen a representation that doesn't give
us any additional headaches for C_BOOL.
>>> OK with the modifications. Note: GCC 4.5 is currently frozen - please
>>> wait until unfrozen.
>>>
>> Thanks for the review (and to Jerry too). Richard G. said on irc that
>> documentation changes were ok at the moment, so I plan to commit to
>> 4.5 as well later today.
>>
>
> Don't wait too long or (better) re-ask before committal. If no problems
> turn up, they will build and release 4.5.0. I don't know whether this
> will be today or in the next days but there won't be any announcement
> before that happens (well, maybe some IRC conversation between Richard
> and Jakub).
You committed with your suggested changes to trunk as r158080, and to
4.4 as r158081. In the end I decided to wait until the dust settles
with 4.5, and I'll commit it there once the tree opens up again for
4.5.1.
--
Janne Blomqvist