This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [4.6 PATCH] -Wunused-but-set-{variable,parameter} (PR c/18624)


I know I am a bit late but a few things:

For new warnings you should use warning_at(). We should always pass
explicit locations. It is a bit more writing but the results is more
clear and it makes -Wsystem-headers happy!

For
+@item -Wunused-but-set-parameter

it should say "This warning is enabled by -Wunused plus -Wextra".

For
+@item -Wunused-but-set-variable
it should say "This warning is enabled by -Wunused". If you want, you
could also say ", which in turn is enabled by -Wall".

Cheers,

Manuel.


On 7 April 2010 00:06, Jakub Jelinek <jakub@redhat.com> wrote:
> Hi!
>
> Here are updated patches for C -Wunused-but-set-* support,
> bootstrapped/regtested on x86_64-linux and
> i686-linux. ?The C parts of the first patch have been approved
> by Joseph already earlier, so I'm just seeking approval for the
> rest of the changes.
>
> Ok for trunk?
>
> ? ? ? ?Jakub
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]