This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [4.6 PATCH] -Wunused-but-set-{variable,parameter} (PR c/18624)
- From: Manuel López-Ibáñez <lopezibanez at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Richard Guenther <rguenther at suse dot de>, Richard Henderson <rth at redhat dot com>, gcc-patches at gcc dot gnu dot org, "Joseph S. Myers" <joseph at codesourcery dot com>
- Date: Wed, 7 Apr 2010 00:56:44 +0200
- Subject: Re: [4.6 PATCH] -Wunused-but-set-{variable,parameter} (PR c/18624)
- References: <20100406220623.GT2817@tyan-ft48-01.lab.bos.redhat.com>
I know I am a bit late but a few things:
For new warnings you should use warning_at(). We should always pass
explicit locations. It is a bit more writing but the results is more
clear and it makes -Wsystem-headers happy!
For
+@item -Wunused-but-set-parameter
it should say "This warning is enabled by -Wunused plus -Wextra".
For
+@item -Wunused-but-set-variable
it should say "This warning is enabled by -Wunused". If you want, you
could also say ", which in turn is enabled by -Wall".
Cheers,
Manuel.
On 7 April 2010 00:06, Jakub Jelinek <jakub@redhat.com> wrote:
> Hi!
>
> Here are updated patches for C -Wunused-but-set-* support,
> bootstrapped/regtested on x86_64-linux and
> i686-linux. ?The C parts of the first patch have been approved
> by Joseph already earlier, so I'm just seeking approval for the
> rest of the changes.
>
> Ok for trunk?
>
> ? ? ? ?Jakub
>