This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[PATCH] Fix __builtin_ia32_vpermil2p* with -mavx (PR target/43667)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Uros Bizjak <ubizjak at gmail dot com>, Sebastian Pop <sebpop at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 6 Apr 2010 17:46:31 +0200
- Subject: [PATCH] Fix __builtin_ia32_vpermil2p* with -mavx (PR target/43667)
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
Hi!
Compiling
typedef double __v2df __attribute__ ((__vector_size__ (16)));
typedef long long __v2di __attribute__ ((__vector_size__ (16)));
__v2df foo (__v2df X, __v2df Y, __v2di C)
{
return __builtin_ia32_vpermil2pd (X, Y, C, 1);
}
with -O2 -mavx ICEs with:
a.c:10:1: error: unrecognizable insn:
(insn 8 7 9 3 a.c:9 (set (reg:V2DF 63)
(unspec:V2DF [
(reg/v:V2DF 60 [ X ])
(reg/v:V2DF 61 [ Y ])
(reg/v:V2DI 62 [ C ])
(const_int 1 [0x1])
] 168)) -1 (nil))
a.c:10:1: internal compiler error: in extract_insn, at recog.c:2103
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
The problem is that these builtins use wrong option mask, the
instructions are guarded with TARGET_XOP, but OPTION_MASK_ISA_AVX
is used. The patch below fixes it (and also uses correct
case labels in ix86_expand_args_builtin - all other cases use
V*_FTYPE_* enum codes, so using MULTI_* defines in that case
is inconsistent).
Ok for trunk and 4.5?
2010-04-06 Jakub Jelinek <jakub@redhat.com>
PR target/43667
* config/i386/i386.c (bdesc_multi_arg): Use OPTION_MASK_ISA_XOP
instead of OPTION_MASK_ISA_AVX for __builtin_ia32_vpermil2p*.
(ix86_expand_args_builtin): Use V*_FTYPE_* enum codes instead of
MULTI_* defines for 4 argument vpermil2p* builtins.
--- gcc/config/i386/i386.c.jj 2010-04-06 11:14:37.000000000 +0200
+++ gcc/config/i386/i386.c 2010-04-06 17:01:15.000000000 +0200
@@ -22472,10 +22472,10 @@ static const struct builtin_description
{ OPTION_MASK_ISA_XOP, CODE_FOR_xop_pcom_tfv4si3, "__builtin_ia32_vpcomtrueud", IX86_BUILTIN_VPCOMTRUEUD, (enum rtx_code) PCOM_TRUE, (int)MULTI_ARG_2_SI_TF },
{ OPTION_MASK_ISA_XOP, CODE_FOR_xop_pcom_tfv2di3, "__builtin_ia32_vpcomtrueuq", IX86_BUILTIN_VPCOMTRUEUQ, (enum rtx_code) PCOM_TRUE, (int)MULTI_ARG_2_DI_TF },
- { OPTION_MASK_ISA_AVX, CODE_FOR_xop_vpermil2v2df3, "__builtin_ia32_vpermil2pd", IX86_BUILTIN_VPERMIL2PD, UNKNOWN, (int)MULTI_ARG_4_DF2_DI_I },
- { OPTION_MASK_ISA_AVX, CODE_FOR_xop_vpermil2v4sf3, "__builtin_ia32_vpermil2ps", IX86_BUILTIN_VPERMIL2PS, UNKNOWN, (int)MULTI_ARG_4_SF2_SI_I },
- { OPTION_MASK_ISA_AVX, CODE_FOR_xop_vpermil2v4df3, "__builtin_ia32_vpermil2pd256", IX86_BUILTIN_VPERMIL2PD256, UNKNOWN, (int)MULTI_ARG_4_DF2_DI_I1 },
- { OPTION_MASK_ISA_AVX, CODE_FOR_xop_vpermil2v8sf3, "__builtin_ia32_vpermil2ps256", IX86_BUILTIN_VPERMIL2PS256, UNKNOWN, (int)MULTI_ARG_4_SF2_SI_I1 },
+ { OPTION_MASK_ISA_XOP, CODE_FOR_xop_vpermil2v2df3, "__builtin_ia32_vpermil2pd", IX86_BUILTIN_VPERMIL2PD, UNKNOWN, (int)MULTI_ARG_4_DF2_DI_I },
+ { OPTION_MASK_ISA_XOP, CODE_FOR_xop_vpermil2v4sf3, "__builtin_ia32_vpermil2ps", IX86_BUILTIN_VPERMIL2PS, UNKNOWN, (int)MULTI_ARG_4_SF2_SI_I },
+ { OPTION_MASK_ISA_XOP, CODE_FOR_xop_vpermil2v4df3, "__builtin_ia32_vpermil2pd256", IX86_BUILTIN_VPERMIL2PD256, UNKNOWN, (int)MULTI_ARG_4_DF2_DI_I1 },
+ { OPTION_MASK_ISA_XOP, CODE_FOR_xop_vpermil2v8sf3, "__builtin_ia32_vpermil2ps256", IX86_BUILTIN_VPERMIL2PS256, UNKNOWN, (int)MULTI_ARG_4_SF2_SI_I1 },
};
@@ -23630,10 +23630,10 @@ ix86_expand_args_builtin (const struct b
nargs = 3;
nargs_constant = 2;
break;
- case MULTI_ARG_4_DF2_DI_I:
- case MULTI_ARG_4_DF2_DI_I1:
- case MULTI_ARG_4_SF2_SI_I:
- case MULTI_ARG_4_SF2_SI_I1:
+ case V2DF_FTYPE_V2DF_V2DF_V2DI_INT:
+ case V4DF_FTYPE_V4DF_V4DF_V4DI_INT:
+ case V4SF_FTYPE_V4SF_V4SF_V4SI_INT:
+ case V8SF_FTYPE_V8SF_V8SF_V8SI_INT:
nargs = 4;
nargs_constant = 1;
break;
Jakub