This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH C] PR 36774 Don't warn missing prototype to nested functions if defined before first use


On Fri, 2 Apr 2010, Shujing Zhao wrote:

> Hi
> -Wmissing-prototype should not trigger nested functions if defined before
> first use. -Wmissing-declaration also have the same problem.
> Only global def would be warn with no previous prototype or declaration if
> defined before first use, While the public_flag of nested function isn't be
> set to 0 before check the warn now. Move forward the check for nested function
> would solve this problem.
> 
> Tested on i686-pc-linux-gnu, double checked the test cases with
> -Wmissing-prototype and -Wmissing-declaration, and no regression.
> 
> Is it ok for 4.6?

OK for 4.6.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]