This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Machine description for the APM83xxx ("Titan" core) PowerPC family
- From: Philipp Tomsich <philipp dot tomsich at theobroma-systems dot com>
- To: David Edelsohn <dje dot gcc at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 1 Apr 2010 16:17:56 +0200
- Subject: Re: [PATCH] Machine description for the APM83xxx ("Titan" core) PowerPC family
- References: <t2g303e1d291004010606j8be22396p7a86ae0ed17439e2@mail.gmail.com>
On Apr 1, 2010, at 3:06 PM, David Edelsohn wrote:
> Thanks for your interest in GCC and contributing support for a new
> PowerPC processor.
>
> Copyright for patches to GCC must be assigned to the Free Software
> Foundation and I cannot find an existing assignment for you or
> Theobroma Systems or Applied Micro. If you did the work under
> contract from Applied Micro, I do not know who actually owns the
> resulting work.
Our contract states, that the copyright on these patches will be assigned to the FSF.
> The patches include a copyright date of 2008, which should be updated.
> Have the patches existed since 2008? Where did they come from.
Oops. We didn't update the header.
The copyright date should read 2009-2010.
> As you mention, the patches mostly are self-contained. The
> TARGET_TITAN_FPU and fsqrt changes are not correct. Titan is not an
> architecture. fsqrts would not be used unless TARGET_PPC_GPOPT (or
> TARGET_POWER2) was enabled. If that occurs, one should track down why
> those flags were enabled or ensure that they are not enabled, not add
> another test to the sqrt pattern.
>
> The primary issue to applying the patch is the copyright assignment.
We'll file the copyright assignment and I'll notify you directly, once this has been done.
Best,
Phil.