This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: ARM patch: Fix PR 40697
- From: Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>
- To: Bernd Schmidt <bernds at codesourcery dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 19 Mar 2010 08:05:57 +0000
- Subject: Re: ARM patch: Fix PR 40697
- References: <4BA2A800.3090108@codesourcery.com>
- Reply-to: ramana dot radhakrishnan at arm dot com
Hi Bernd,
I have no rights to approve or reject your patch but a couple of points
spring to mind. Firstly, could you consider adding a test for this in
gcc.target/arm ?
> Fixed by tweaking the rtx costs. Regression tested on arm-elf{,mthumb}.
> Ok (possibly for 4.6)?
Could you also consider testing your patches on arm-eabi rather than on
arm-elf ? Whilst it's not something that will cause problems for testing
this patch, arm-elf is in maintenance mode only while arm-eabi is the
primary target for the ARM port. I think a couple of docs on the site
that refer to building combined trees and using arm-elf as the canonical
target should also get updated to be using arm-eabi instead.
cheers
Ramana