This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] S/390: Make enable-decimal-float the default


On 12/03/2010 13:26, Andreas Krebbel wrote:

  Given that this test here only enables decimal float by default for specific
OS/cpu combinations:

>     case $host in
> !     powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | s390*-*-linux*)
>         enable_decimal_float=yes
>         ;;

... I think that this test here:

>   # x86's use BID format instead of DPD
> ! case x$enable_decimal_float in
> !   xyes)
> !     case $host in
> !       i?86*-*-linux* | x86_64*-*-linux*)
> ! 	enable_decimal_float=bid
> ! 	;;
> !       *)
> ! 	enable_decimal_float=dpd
> ! 	;;
> !     esac
> !     ;;
> !   xno)
> !     # ENABLE_DECIMAL_FLOAT is set to 0. But we have to have proper
> !     # dependency on libdecnumber.
> !     enable_decimal_float=dpd
> !     ;;
> ! esac
> ! 

... should in fact say:

> !     case $host in
> !       i?86*-*-* | x86_64*-*-*)

  ... so that if anyone manually configures with --enable-decimal-float on any
non-linux x86 target, the correct variant will still be automatically chosen
for them.

    cheers,
      DaveK



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]