This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFA] A small fix for IRA
- From: Vladimir Makarov <vmakarov at redhat dot com>
- To: Jie Zhang <jie at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 08 Mar 2010 12:02:15 -0500
- Subject: Re: [RFA] A small fix for IRA
- References: <4B945A8E.2080704@codesourcery.com>
Jie Zhang wrote:
When working on a GCC bug, I found this. We should use `-' instead of
`+', otherwise "use + 1" would fall out of the array boundary. Is it OK?
Yes, that is definitely a typo. So your patch is ok. Thanks for
finding this.
P.S. By the way, the comparison is not necessary at all because use <
n_operands is always true and if constraints[use][0]=='%' than use + 1 <
n_operands. But it is good to have it for readability.