Re: PATCH: Fix broken dg-skip-if in two gcc.target/i386 testcases

[Janis Johnson <janis187 at us dot ibm dot com>]

On Mon, 2010-03-01 at 22:09 +0100, Rainer Orth wrote:
> Janis Johnson <janis187@us.ibm.com> writes:
> 
> >> Perhaps DejaGnu's framework.exp (check_conditional_xfail) should warn if
> >> the include arg is missing, since it is required?
> >
> > Ouch.  It should give an error.  A quick look shows lots of other tests
> > that use dg-skip-if without all of the required arguments.  I'll make a
> > pass through all of GCC's testsuite directives to check for that, with
> > corresponding changes to fix tests.
> 
> Great, thanks.  This will save someone quite some time debugging.
> 
> >> This is just another case where I've been bitten by the sorry state of
> >> documentation for our DejaGnu test framework: it would really help to
> >> have this stuff in one place in the internals manual instead of
> >> scattered over READMEs, the WiKi, and the code.  I fear this would have
> >> to be done by someone who really knows the framework, though, since
> >> rediscovering all the quirks and corner cases of the testsuite for
> >> anyone else is bound to be a nightmare.
> >
> > The testsuite is documented in the internals manual.  In particular, see
> > http://gcc.gnu.org/onlinedocs/gccint/Test-Directives.html#Test-Directives.
> > Is that what you wanted, or is there more that you'd like to see there?
> 
> Oops, I'd completely overlooked that.  Time to read the internals manual
> again (it's been a couple of years).  I had only seen the stuff in the
> Wiki, but haven't yet checked if there's anything in the Wiki that's not
> in gccint.  If I find something missing, I'll notify you.

You're not the first person who has missed the testsuite documentation.
I'll investigate moving it up so it appears in the top-level table of
contents for the GCC Internals Manual.

> Sorry for the noise ;-(

It wasn't noise at all, it was quite useful.

Janis