This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, Fortran] PR42888: [4.5 Regression] ICE in fold_convert_loc, at fold-const.c:2670

From: Janus Weil <janus at gcc dot gnu dot org>
To: Tobias Burnus <burnus at net-b dot de>
Cc: gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Sun, 31 Jan 2010 23:00:20 +0100
Subject: Re: [Patch, Fortran] PR42888: [4.5 Regression] ICE in fold_convert_loc, at fold-const.c:2670
References: <854832d41001300411ya86336ana4ab1d0db3208664@mail.gmail.com> <4B65A2AF.2080902@net-b.de> <854832d41001311035u66700378k2ccbf8f639ca27ac@mail.gmail.com> <4B65DE11.2090006@net-b.de>

>>> Actually, why do you need a memcopy and cannot do a normal assignment?
>>>
>> for the test case I attached, a normal assignment would be sufficient.
>> The memcpy is needed for the general case that the dynamic type (which
>> is being allocated) is different
>>
> Thanks for the clarification. The patch is OK. (Maybe one should add a
> note regarding using memcopy due to the dynamic type - if others stumble
> over it; but possibly it is not really needed.)

Thanks. Committed as r156418 (with an additional comment on the memcpy).

Cheers,
Janus

References:
- [Patch, Fortran] PR42888: [4.5 Regression] ICE in fold_convert_loc, at fold-const.c:2670
  - From: Janus Weil
- Re: [Patch, Fortran] PR42888: [4.5 Regression] ICE in fold_convert_loc, at fold-const.c:2670
  - From: Tobias Burnus
- Re: [Patch, Fortran] PR42888: [4.5 Regression] ICE in fold_convert_loc, at fold-const.c:2670
  - From: Janus Weil
- Re: [Patch, Fortran] PR42888: [4.5 Regression] ICE in fold_convert_loc, at fold-const.c:2670
  - From: Tobias Burnus

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]