This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [vta, graphite?] propagate degenerate phi nodes into debug stmts
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Alexandre Oliva <aoliva at redhat dot com>
- Cc: Richard Guenther <richard dot guenther at gmail dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 29 Jan 2010 08:24:11 -0800
- Subject: Re: [vta, graphite?] propagate degenerate phi nodes into debug stmts
- References: <orfx8ph31l.fsf@livre.localdomain> <84fc9c000911080156iff6d687o26db10af3e9fba5d@mail.gmail.com> <ortywuw6bb.fsf@livre.localdomain> <84fc9c000911170739v76a2e911vc6794e597c8d134e@mail.gmail.com> <ord43fgmvw.fsf@livre.localdomain> <84fc9c000911190255q12e2a1c8nc0af0587883d7455@mail.gmail.com> <orfx89eei5.fsf@livre.localdomain> <6dc9ffc80912050502t5420c654qbb7dc7acc8782b9c@mail.gmail.com> <6dc9ffc80912221655x1d1755c8nc41f66649a5a8f7a@mail.gmail.com>
On Tue, Dec 22, 2009 at 4:55 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Sat, Dec 5, 2009 at 5:02 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Fri, Nov 20, 2009 at 1:23 AM, Alexandre Oliva <aoliva@redhat.com> wrote:
>>> On Nov 19, 2009, Richard Guenther <richard.guenther@gmail.com> wrote:
>>>
>>>> On Thu, Nov 19, 2009 at 5:27 AM, Alexandre Oliva <aoliva@redhat.com> wrote:
>>>>> On Nov 17, 2009, Richard Guenther <richard.guenther@gmail.com> wrote:
>>>>>
>>>>>> Well, just adjust degenerate_phi_result to do instead of calling
>>>>>> operand_equal_p
>>>>>
>>>>>> ? else if (TREE_CODE (arg) != TREE_CODE (val)
>>>>>> ? ? ? ? ? ? ?|| (TREE_CODE (arg) == SSA_NAME
>>>>>> ? ? ? ? ? ? ? ? ?&& arg != val)
>>>>>> ? ? ? ? ? ? ?|| !operand_equal_p (arg, val, 0))
>>>>>> ? ? break;
>>>>>
>>>>>> that should fix it.
>>>>>
>>>>> Good idea.
>>>
>>>>> Here's what I'm testing now.
>>>
>>>> Ok if it passes testing.
>>>
>>> Thanks, but arg could be NULL, and then TREE_CODE (val) would crash.
>>>
>>> The fixed patch below corrects the two regressions I got testing the
>>> patch on x86_64-linux-gnu. ?Save for new regressions, I'll check in the
>>> revised version as soon as my current round of testing completes.
>>>
>>>
>>
>> This patch caused:
>>
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42299
>>
>
> This patch also caused:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42395
>
This also caused:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42897
--
H.J.